[Bug 436330] Review Request: libtrash - Libraries to move files to a trash-folder on delete

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtrash - Libraries to move files to a trash-folder on delete


https://bugzilla.redhat.com/show_bug.cgi?id=436330





------- Additional Comments From zprikryl at redhat.com  2008-07-01 08:13 EST -------
First at all, thank you for reviewing :-)

(In reply to comment #2)
> - The spec you mentioned from the URL does not match the spec in the SPRM

Fixed.

> - Make sure that the /sbin/ldconfig lines are as follows:
> 
> %post -p /sbin/ldconfig
> 
> %postun -p /sbin/ldconfig

Yes, the lines look like those above.

> - Don't use %{name}-latest in the URL, use %{name}-%{version}. Yes, the URL is
> still valid.

Fixed.

> - libtrash.i386: W: devel-file-in-non-devel-package /usr/lib/libtrash.so
>   - move %{_libdir}/libtrash.so to a -devel package

This library is the core of libtrash package. So I think, that it doesn't make a
sense to make another package. If so, then the first package would contain only
configuration file and doc files and the second one would contain only the
library. Furthermore, the first one would have to have second one in
requirements, otherwise the whole thing will not work.

> - Other rpmlint errors:
> - libtrash.i386: E: no-ldconfig-symlink /usr/lib/libtrash.so.3.2

Fixed.

Spec URL: http://zprikryl.fedorapeople.org/libtrash.spec
SRPM URL: http://zprikryl.fedorapeople.org/libtrash-3.2-1.fc10.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.