[Bug 452872] Review Request: bmake - The NetBSD make(1) tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bmake - The NetBSD make(1) tool


https://bugzilla.redhat.com/show_bug.cgi?id=452872


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-07-01 13:29 EST -------
Some random comments 0.20080515-1:

* Versioning
  - If you think %bmake_date should not be treated as a formal
    version, then versioning this package as
    0-0.X.%{bmake_date}%{?dist}
    (i.e. version 0, release number 0.X.%{bmake_date} with suffix
          %{?dist} where X is incremented every time you modify
          your spec file)
    is better.

  - Also please remove Epoch.

* BuildRequires
  - This does not build on dist-f10:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=687706
    "BuildRequires: util-linux" is needed (on F-10 util-linux-ng
    Provides util-linux)

* %prep usage
----------------------------------------------------------------
%setup -q -n bmake
tar -x -z -f %{SOURCE1}
----------------------------------------------------------------
  - can be replaced by
----------------------------------------------------------------
%setup -q -n %{name} -a 1
----------------------------------------------------------------

* %defattr
  - Now we recommend %defattr(-,root,root,-)

* Directory issue
  - The man directory %{_mandir}/cat1 is nonusual. Please move
    the man file to section 1 or explain why you want to "create"
    cat1 directory.

* Permission issue
  - The directory %{_datadir}/mk has 0775 permission, which should usually
    be 0755.

  - And bmake.1 has 0444 permission, which should be 0644.

! Timestamps
  - This package installs many .mk files which are not modified during
    build and preserving timestamps on those files are preferable.
    Consider to add
-----------------------------------------------------------------
sed -i.timestamp -e 's|^cp_f=-f|cp_f=-pf|' mk/install-mk
-----------------------------------------------------------------
    at %prep to keep timestamps on those files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.