[Bug 452901] Review Request: ocspd - OpenCA OCSP Daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocspd - OpenCA OCSP Daemon


https://bugzilla.redhat.com/show_bug.cgi?id=452901





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-07-01 14:15 EST -------
Would you update the new srpm then? 
(note: please change the release number every time you modify your package 
       when version number does not change, otherwise we are just confused.
       Also, if this uses a "release candidate" tarball, the current versioning
       does not follow Fedora naming guidelines:
      
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages )

Some very quick random remarks (only just watching your spec file)
* %SOURCE must be given with full URL:
   https://fedoraproject.org/wiki/Packaging/SourceURL

* Please do not specify Vendor: item. Fedora builder automatically tags this item as
  "Fedora Project".

* %{openssl_req} tag is redundant. Even Fedora 1 has 0.9.7a openssl.

* Also, "Requires: openssl" should be removed. rpmbuild automatically adds
libraries dependency
  to binary rpms, which will correctly pick out needed openssl.

* Please remove redundant [ -n "${RPM_BUILD_ROOT}" -a "${RPM_BUILD_ROOT}" != '/'
] &&
  part.

* The directory %{_sysconfdir}/ocspd/ is not owned by any package.

* Perhaps %{_sysconfdir}/ocspd/ocspd.conf is listed twice.

* Please use %{_initrddir} instead of %{_sysconfdir}/rc.d/init.d

* We now recommend %defattr(-,root,root,-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.