[Bug 452714] Review Request: Quassel - Distributed IRC Client and Core application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Quassel - Distributed IRC Client and Core application


https://bugzilla.redhat.com/show_bug.cgi?id=452714





------- Additional Comments From rdieter at math.unl.edu  2008-07-01 14:53 EST -------
1.  MUST: use %{_bindir} instead of /usr/bin in %files

2.  MUST: Refer to qt4, not qt, to avoid ambiguity.  In short, s/qt-/qt4-/

3.  MUST: drop kde4_macros_api business.  This is a qt-only app, not a kde4 
one.

4.  SHOULD:  use %{_qt4_qmake} macro instead of qmake-qt4


rpmlint on latest F-9 koji scratch builds: (x86_64)
$ rpmlint *.rpm
quassel.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 7)
quassel.src: E: description-line-too-long Quassel IRC is a modern, distributed 
IRC client, meaning that one (or multiple) client(s) can attach to and detach 
from a central core --
quassel.src: E: description-line-too-long much like the popular combination of 
screen and a text-based IRC client such as WeeChat, but graphical
quassel.src: W: no-version-in-last-changelog
quassel.src: W: strange-permission quassel.spec 0777
quassel.x86_64: E: description-line-too-long Quassel IRC is a modern, 
distributed IRC client, meaning that one (or multiple) client(s) can attach to 
and detach from a central core --
quassel.x86_64: E: description-line-too-long much like the popular combination 
of screen and a text-based IRC client such as WeeChat, but graphical
quassel.x86_64: W: no-version-in-last-changelog
quassel-client.x86_64: W: no-version-in-last-changelog
quassel-core.x86_64: E: description-line-too-long The Quassel IRC Core 
maintains a connection with the server, and allows for multiple clients to 
connect
quassel-core.x86_64: W: no-version-in-last-changelog
4 packages and 0 specfiles checked; 5 errors, 6 warnings.


I'll review a bit more after trying these out to see how well things work.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.