[Bug 452516] Review Request: perl-AnyEvent - Framework for multiple event loops

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-AnyEvent - Framework for multiple event loops


https://bugzilla.redhat.com/show_bug.cgi?id=452516


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From tibbs at math.uh.edu  2008-07-02 15:47 EST -------
Not much to say here; this looks fine.

* source files match upstream:
   ce4f22202f705dee0e4303b85b1aa6475afadc3f50d0586b50a3966ea8633cb5  
   AnyEvent-4.152.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(AnyEvent) = 4.152
   perl(AnyEvent::Base)
   perl(AnyEvent::CondVar)
   perl(AnyEvent::CondVar::Base)
   perl(AnyEvent::DNS) = 4.151
   perl(AnyEvent::Handle) = 4.151
   perl(AnyEvent::Impl::EV)
   perl(AnyEvent::Impl::Event)
   perl(AnyEvent::Impl::EventLib)
   perl(AnyEvent::Impl::Glib)
   perl(AnyEvent::Impl::POE)
   perl(AnyEvent::Impl::Perl) = 4.151
   perl(AnyEvent::Impl::Tk)
   perl(AnyEvent::Socket) = 4.151
   perl(AnyEvent::Util) = 4.151
   perl-AnyEvent = 4.152-1.fc10
  =
   perl(:MODULE_COMPAT_5.10.0)
   perl(AnyEvent)
   perl(AnyEvent::DNS)
   perl(AnyEvent::Handle)
   perl(AnyEvent::Socket)
   perl(AnyEvent::Util)
   perl(Carp)
   perl(Errno)
   perl(Event)
   perl(Event::Lib)
   perl(Fcntl)
   perl(Glib)
   perl(POE)
   perl(Scalar::Util)
   perl(Socket)
   perl(Time::HiRes)
   perl(Tk)
   perl(base)
   perl(strict)

* %check is present and all tests pass:
   All tests successful, 1 test skipped.
   Files=10, Tests=74,  1 wallclock secs ( 0.35 cusr +  0.07 csys =  0.42 CPU)
   (the skipped test requires the network)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.