[Bug 442329] Review Request: gnome-lirc-properties - Infrared Remote Controls setup tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-lirc-properties - Infrared Remote Controls setup tool


https://bugzilla.redhat.com/show_bug.cgi?id=442329


dan at danny.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From dan at danny.cz  2008-07-03 11:29 EST -------
> > bugs
> > * %{_sysconfdir}/dbus-1/system.d/*.conf must be marked as %config
> 
> It's not a configuration file, and it shouldn't be marked as %config, otherwise
> newer versions of gnome-lirc-properties might not launch the service properly.

OK, there is nothing specific in the Guidelines and some other packages mark
such files as %config. An improvement to rpmlint will be required :-)

> > * desktop file not installed or validated
> > (https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files + some
> > discussion on fedora-{devel,packaging} regarding the use of
> > desktop-file-validate), calling desktop-file-validate should be sufficient in
> > this case
> 
> I'm not the one providing the desktop file, it's an upstream file. I can
> certainly add a validate call, but using install is useless, as we're not
> providing the desktop file ourselves.

Yes, that is correct only to validate the desktop when an upstream version is used.

This PACKAGE is APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.