[Bug 453713] Review Request: mm3d - 3D model editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mm3d - 3D model editor


https://bugzilla.redhat.com/show_bug.cgi?id=453713





------- Additional Comments From kwizart at gmail.com  2008-07-03 13:59 EST -------
* According to our packaging guidelines, the package name is the name of the
tarball. But in this case, the real name of the software seems to be
misfitmodel3d where mm3d is the reducted name. Maybe there will be a problem while
* You have picked an development version. According to the remaining patch
needed to be supported on Fedora, it is probably needed. (I will test for
runtime usability)
* It would be nice to have lua pkg-config detection within configure.in (instead
of parsing the %configure )
* mock build in rawhide succeed for all primary arches
http://koji.fedoraproject.org/koji/taskinfo?taskID=694800
* runtime library requirement (rpm -qR mm3d) are the same for mock build and
local build (tested on F-8 x86_64).
* rpmlint is quiet on installed package.
* I tought we started to avoid using "fedora" with desktop file (at least for
new packages), but according to
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage
this hasn't been updated, so I leave this up to you.
* The desktop file contains mimetype, you need to run update-desktop-database
according to 
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
* DocPath=mm3d/index.html
I'm not sure this path remains correct now that the docs have moved. I cannot
test as i'm not a KDE users. But maybe it will be better to use
%doc %{_docdir}/%{name}/* instead of removing and picking it from the buildtree
(this will prevent to bundle Makefile.* at least).
* Translation are present in /usr/share/mm3d/i18n (even qt_??.qm)
I don't know if qt4 translations can obey to the find_lang macro and then be
installed in /usr/share/locales/...
At least providing the even qt_??.qm seems wrong to me (and seems to work
without them)
* The plugin menu seems empty whereas you have packaged two modules for mm3d.
Maybe there is something wrong with the plugin path within the code (at least,
it do not work on F-8 x86_64). So I cannot import/export 3ds files.
So -DSHARED_PLUGINS=\\\"%{_libdir}/%{name}\\\"" doesn't seems enought.
I cannot make the plugins appear in the menu with using ln -sf /usr/lib64/mm3d
/usr/share/mm3d/plugins either.
* Be careful with the fact that this package bundled it's own copy of the lib3ds
library.




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.