[Bug 266841] Review Request: php-pear-propel_runtime - An Object Relational Mapping (ORM) framework for PHP5
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jul 4 02:57:20 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-propel_runtime - An Object Relational Mapping (ORM) framework for PHP5
https://bugzilla.redhat.com/show_bug.cgi?id=266841
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |tibbs at math.uh.edu
Status|NEW |ASSIGNED
Flag| |fedora-review+
------- Additional Comments From tibbs at math.uh.edu 2008-07-03 22:57 EST -------
You could include a dependency on the log package if you like; it's only 52K and
doesn't have significant dependencies. In the end, that's up to you.
Anyway, I think this is done now.
* source files match upstream:
5957f1543b15d8be1246fe562587ed5d8904a66d2be71151f4db0dc7fe96fa1d
propel_runtime-1.3.0RC1.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
php-pear(pear.phpdb.org/propel_runtime) = 1.3.0
php-pear-propel_runtime = 1.3.0-0.2.rc1.fc10
=
/bin/sh
/usr/bin/pear
php >= 5.2.0
php-channel(pear.phpdb.org)
php-dom
php-pdo
php-pear
php-xml
* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets OK (pear module registration).
* code, not content.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the Fedora-package-review
mailing list