[Bug 450189] Review Request: guake - Drop-down terminal for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guake - Drop-down terminal for GNOME


https://bugzilla.redhat.com/show_bug.cgi?id=450189





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-07-04 07:22 EST -------
(In reply to comment #15)
> Undoubtedly. But nevertheless in your patch checking disabled compleatly (if
> test -z ""; then). 
Not "my" patch...

> In my patch check is working successfully: if test -z "$(
> echo $ac_pvte_result | grep -v 'could not import gtk' )"; then. In case if
> occurs other error, it is not be greped.
Well, your patch may be better, however I leave it to the submitter
which to choose. The point is this configure check requests that 
this srpm must have "Requires: vte, pygtk2".
If a packager is aware of it, the difference of the patch does not really matter.

By the way, when adopting your patch, please keep in mind that your patch
adds some BuildRequires (perhaps you are usually using Mandriva, however
Fedora people are very sensitive to Requires/BuildRequires and many other packging
issue ).



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.