[Bug 453847] Review Request: gpt - The Grid Packaging Toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gpt - The Grid Packaging Toolkit


https://bugzilla.redhat.com/show_bug.cgi?id=453847





------- Additional Comments From pertusus at free.fr  2008-07-04 09:45 EST -------
It seems strange to me to need gpt for globus in fedora, on pure
rpm system it should not be useful. That being said, it doesn't mean
that gpt cannot be in fedora.

I think that the name is too short, it would be better to have something
longer.

You have a fair amount of patches. Is upstream aware of these?

Why do you change _ in - in script file names?

Reading the /usr/share/gpt/lib/perl/Grid/GPT/LocalEnv.pm
file it seems that gtar/gzip is used, so a Requires should be needed,
in stead of the perl(Archive::Tar) Requires. Also rpm and rpmbuild
seems to be used so maybe some Requires are missing.

Why aren't the dtds in some dtd directory?

There are some automake duplicated files, this deserves a comment.
Also gpt-bootstrap.sh seems to require all the autotools and it is not
very clear where it is documented.

the globus_core-src.tar.gz file seems also dubious to me.

Do you really need to rerun the autotools? It doesn't seems clear
to me based on the patches.

Instead of populating %{docdir} yourseld, I wuold suggest using an 
in-source directory and %doc. This allows to better keep timestamps 
without much work. Like:

rm -rf __dist_docs
mkdir __dist_docs
mv $RPM_BUILD_ROOT%{_sysconfdir}/%{name}/dtd __dist_docs/
mv $RPM_BUILD_ROOT%{_datadir}/%{name}/gpt_rpm.spec __dist_docs/
iconv -f iso-8859-1 -t utf-8 LICENSE > LICENSE.utf8
touch -c -r LICENSE LICENSE.utf8
mv LICENSE.utf8 LICENSE

and in %files:
%doc __dist_docs/* CHANGES INSTALL README

For patch, 2 suggestions, use
%patch0 -p1 -b .globus
to be able to use gendiff more easily, and name patch like
Patch0:         %{name}-3.2-globus.patch
to know in which version the patch was introduced.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.