[Bug 452078] Review Request: node - Simple node front end, modelled after the node shells of TheNet and G8BPQ nodes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: node - Simple node front end, modelled after the node shells of TheNet and G8BPQ nodes


https://bugzilla.redhat.com/show_bug.cgi?id=452078


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From tibbs at math.uh.edu  2008-07-04 16:35 EST -------
OK, finally getting back to this.

The license should be GPLv2+ unless you can point out some place where it is
limited to GPLv2 only.

You must include the COPYING file as documentation.

This package does not use the proper set of compiler flags.  You must pass
$RPM_OPT_FLAGS or %{optflags} to the compiler.  You may need to patch parts of
the package's build system in order to get this to work.

* source files match upstream:
   41879021150084e2eb923f414dbd1082af1d46e10313a52137c9ce1e7eff64d5  
   node-0.3.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field does not match the actual license.
* license is open source-compatible.
X license text included upstream but not included in the package.
* latest version is being packaged.
* BuildRequires are proper.
X compiler flags are not correct.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   config(node) = 0.3.2-3.fc10
   node = 0.3.2-3.fc10
  =
   /bin/sh
   /sbin/service
   config(node) = 0.3.2-3.fc10
   libax25.so.0()(64bit)
   libax25io.so.0()(64bit)
   libz.so.1()(64bit)
   xinetd

* %check is not present; no test suite upstream.  I have no idea how to go about 
   testing this.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (xinetd restart).
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.