[Bug 227190] Review Request: php-pear-Auth-OpenID - PHP OpenID

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Auth-OpenID - PHP OpenID


https://bugzilla.redhat.com/show_bug.cgi?id=227190





------- Additional Comments From axel.thimm at atrpms.net  2008-07-04 17:01 EST -------
Sorry Peter, I missed comment 16!

-%(%{__id_u} -n): This is not considered the better buildroot, in fact we had
the wording of the guidelines changed to provide better alternatives last year.

%{__tool} vs tool is a matter of style used differently by every packager out
there. Personally I think this is overmacroizing things, as either the rpmbuild
setup is pointing to sane PATHs or you're in deep trouble anyway due to
non-absolute calls to binaries in Makefiles etc.

I'll add the dos2unix fixes, thanks for spotting!

I didn't understand the issue with %{pear_phpdir}/* vs %{pear_phpdir}/data. The
globbing does include all, or not?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.