[Bug 445152] Review Request: yacpi - ncurses based acpi viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yacpi - ncurses based acpi viewer


https://bugzilla.redhat.com/show_bug.cgi?id=445152


rakesh.pandit at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rakesh.pandit at gmail.com




------- Additional Comments From rakesh.pandit at gmail.com  2008-07-05 08:19 EST -------
I am not sponsored yet, so cannot review. Just have some helpful remarks 

Could not build:
No package libacpi-devel

Without building I have a small suggestions:

1. You should consistently use %{name} e.g Source0 link or in %files (man page)
2. For single file encoding change this one looks lot simple and clean
 iconv -f iso-8859-1 -t utf-8 -o CHANGELOG{.utf8,}
 mv CHANGELOG{.utf-8}

Yours is also okay, it is your choice.

3. description needs a bit correction:
    This part "battery status and ac status" is mentioned twice.

4. Preferred Buildroot tag is %(mktemp -ud %{_tmppath}/%{name}-%{version}-
%{release}-XXXXXX)



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.