[Bug 227190] Review Request: php-pear-Auth-OpenID - PHP OpenID

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Auth-OpenID - PHP OpenID


https://bugzilla.redhat.com/show_bug.cgi?id=227190





------- Additional Comments From lemenkov at gmail.com  2008-07-05 14:55 EST -------
> -%(%{__id_u} -n): This is not considered the better buildroot, in fact we had
the wording of the guidelines changed to provide better alternatives last year.

I'm just following the current (at that moment guidelines). It's not a blocker,
I think.

> %{__tool} vs tool is a matter of style used differently by every packager out
there. 

Likewise. I'm just following guidelines (I'm not a keen in php/pear so I'm not
sure what is important and what is not).

> I'll add the dos2unix fixes, thanks for spotting!

OK.

> I didn't understand the issue with %{pear_phpdir}/* vs %{pear_phpdir}/data.
The globbing does include all, or not?

My wish was to avoid multiple ownership of directories. But looks like this kind
of inclusion is a common practice for php-pear-Auth-* packages.

Anywy, I'm waiting for your next release.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.