[Bug 451996] Review Request: prover9 - Thereom Prover and Countermodel Generator

bugzilla at redhat.com bugzilla at redhat.com
Sun Jul 6 18:09:27 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: prover9 - Thereom Prover and Countermodel Generator


https://bugzilla.redhat.com/show_bug.cgi?id=451996





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-07-06 14:09 EST -------
For 200805a-2:

* Namespace issue
  - Please fix for too generic names on man pages, too.
    (by the way, is it really needed to create all symlinks
     for man pages, too?)

* Documents
  - prove9-apps subpackage can be installed without prove9 package.
    In such case, documents like COPYING and so are not installed,
    which is wrong.
    At least some files should be moved to prove9-apps subpackage.

* rpmlint issue:
----------------------------------------------------------------
prover9-apps.i386: W: spurious-executable-perm
/usr/share/doc/prover9-apps-200805a/apps.examples/run-all
prover9-apps.i386: W: doc-file-dependency
/usr/share/doc/prover9-apps-200805a/apps.examples/run-all /bin/csh
prover9-devel.i386: W: spurious-executable-perm /usr/lib/libladr.a
----------------------------------------------------------------
  - run-all script has executable permission bits and this adds
    unneeded Requires (/bin/csh) to -apps subpackage.
    Please fix the permission to 0644.
  - Static archives should have 0644 permission.

* test
  - build.log shows
----------------------------------------------------------------
   284  /bin/cp -p utilities/* bin
   285  **** Now try 'make test1'. ****
----------------------------------------------------------------
    Would you consider to add %check section and do some tests there?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list