[Bug 454166] Review Request: griv - a gtk rivchat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: griv - a gtk rivchat


https://bugzilla.redhat.com/show_bug.cgi?id=454166





------- Additional Comments From wolfy at nobugconsulting.ro  2008-07-06 16:39 EST -------
two minor nitpicks:
- please bump the release each time you modify the spec. this makes life easier
for whoever wants to track the differences
- you have some duplicate BuildRequires: libX11-devel (by gtk2-devel),
xorg-x11-proto-devel (by libX11-devel)

Now, the serious problems
- the mandatory compiling flags are not obeyed to. See
https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags for details
- packaging a desktop file is not enough to make is useful. You should also
follow https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files in
order to a) make sure it is correct and b) install it



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.