[Bug 453026] Review Request: xmp - A multi-format module player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmp - A multi-format module player


https://bugzilla.redhat.com/show_bug.cgi?id=453026





------- Additional Comments From rpm at greysector.net  2008-07-07 14:01 EST -------
Spec URL: http://rathann.fedorapeople.org/review/xmp.spec
SRPM URL: http://rathann.fedorapeople.org/review/xmp-2.5.1-2.fc8.src.rpm

(In reply to comment #2)
> On naming, it looks like most audacious plugin packages are named
> audacious-plugins-*.  The only exception is audacious-plugin-fc.  The "plugins"
> packages appear to be all built from a single audacious-plugins src.rpm, so it
> makes sense to use "plugins" for that.  The fc plugin is a single plugin built
> from its own audacious-plugin-fc.src.rpm package.
[...]
> Thoughts?  "audacious-plugin-xmp" is consistent with the fc plugin, so I'm
> okay with that naming.

I think *-plugin-* is a better name, too.

(In reply to comment #3)
> Looks good with the exception of the OCL-licensed gdm.txt which needs to be
> addressed.

Fixed in 2.5.1-2 by repackaging the tarball without the problematic file.
I'll ask upstream about removing that file later.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.