[Bug 454171] Review Request: gfs-ambrosia-fonts - GFS Ambrosia majuscule Greek font

bugzilla at redhat.com bugzilla at redhat.com
Tue Jul 8 20:48:24 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gfs-ambrosia-fonts - GFS Ambrosia majuscule Greek font


https://bugzilla.redhat.com/show_bug.cgi?id=454171





------- Additional Comments From muepsj at gmail.com  2008-07-08 16:48 EST -------
This is an informal review for getting sponsored.

MUST items:

Rpmlint:

kaappi >: rpmlint gfs-ambrosia-fonts-20080624-1.fc10.src.rpm
../SPECS/gfs-ambrosia-fonts.spec
1 packages and 1 specfiles checked; 0 errors, 0 warnings.
kaappi >:

- Rpmlint: OK
- Package name: OK
  - Version: Based on a date: OK
- Specfile name: OK
- Packaging guidelines: OK
- Software license: OK
- License field in the spec file: OK
- License text from the source zip file included in %doc: OK (though could maybe
list the two files explicitly)
- The spec file is in American English: OK
- The spec fils is legible: OK
- Source files the same as provided by upstream: OK
- Builds into a binary RPM; not architecture dependent, builds ok. OK
- No BuildRequires; doesn't depend on any libraries or tools besides the base
system: OK
- No locales, no need to use %find_lang: OK
- No shared libraries: OK
- Package not relocatable: OK
- Package owns all the created directories: OK
- No duplicates in %files: OK
- File permissions: OK
- Proper %clean section: OK
- Consistent macro use: OK
- Fonts with a free license are permissible content: OK
- No large documentation files, no -doc subpackage: OK
- Font doesn't need %doc files for operation: OK
- No header files, no -devel subpackage: OK
- No static libraries, no -static subpackage: OK
- No dependency on pkgconfig: OK
- No .la archives: OK
- Not a GUI app, no .desktop file: OK
- No other packages' files owned: OK
- rm -rf %{buildroot} is run at the beginning of %install: OK
- All filenames valid UTF-8: OK

Some SHOULD items:
- License texts included as a separate file: OK
- Description and summary translations not included, probably not available: -
- Builds into a binary package probably on all architectures, since has nothing
arch dependent: OK
- Works as described: The Ambrosia font is available in KDE's appearance
configuration's font menus: OK

The font also complies with Fedora's Font policy.

I think the package is ok for inclusion in Fedora.



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list