[Bug 454940] Review Request: rcssbase - Base libraries for Robocup Soccer Server (2D)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rcssbase - Base libraries for Robocup Soccer Server (2D)


https://bugzilla.redhat.com/show_bug.cgi?id=454940





------- Additional Comments From hedayat at grad.com  2008-07-10 18:33 EST -------
A self review!:
- rpmlint output: rpmlint complains about absence of docs in the -devel
sub-package. I cannot find any relevant files to put as doc files for -devel package

- package name is equal to the upstream name
- spec file name is correct
- the package is under LGPLv2 or later
- License field matches with the actual license
- License file is included in the package docs
- the spec file is (hopefully!) in American English
- the spec file is legible (I think)
- source code matches upstream (I can't compare since I've only one package
which is what I downloaded from Internet and is included in the SRPM. Anyway the
md5sum output is: 13cc197d352744ff03b13360f8852e90  rcssbase-12.1.0.tar.gz

- I am able to build the package in Fedora 9 on my system (32bit)
- I'm not aware of any specific architectures which the package can't be built in
- It seems that Build Requires section is correct. I can build the package using
mock
- No locale specific stuff in this package
- Runs ldconfig in %post & %postun
- Package is not relocatable
- The package owns its directories
- Doesn't contain duplicate files 
- file permissions should be OK
- contains a %clean section
- have consistent use of macros
- header files are in -devel sub-pacakge. No -static package needed.
- -devel package requires the base package
- doesn't contain any .la files
- Not a GUI application
- calls rm -rf %{buildroot} in %install
- filenames are in UTF-8

Should Items:
- The package builds in python

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.