[Bug 454867] Review Request: brickshooter - A small puzzle game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: brickshooter - A small puzzle game


https://bugzilla.redhat.com/show_bug.cgi?id=454867


nphilipp at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?(cheekyboinc at foresi
                   |                            |ghtlinux.org)




------- Additional Comments From nphilipp at redhat.com  2008-07-11 09:59 EST -------
Bad:

MUSTFIX: name probably violates trademark, see http://www.brickshooter.com --
while at it, verify that the contained artwork is indeed made by the author or
properly licensed ("This game was written from scratch in 4 days", I don't know
if this just covers the code or artwork as well).

MUSTFIX: corrected grammar of description:

brickshooter is a small puzzle game for linux, where you have
to clear the central area from differently colored bricks. Three or
more adjacent bricks of the same color will vanish. You can shoot
bricks into the playing field from the fringes.

MUSTFIX: doesn't own all directories that it creates
(/usr/share/icons/hicolor/*/apps) -> Requires: hicolor-icon-theme

MUSTFIX: use $RPM_OPTFLAGS or %optflags as compiler flags (probably needs
changes in the Makefile)

Not so good:

SHOULDFIX: license text not in %doc due to not being in the source tarball --
please ask upstream to include the license, then include it as well.

Good:

- rpmlint checks return:

  1 packages and 0 specfiles checked; 0 errors, 0 warnings.


- package meets naming guidelines (except trademark issue above)
- package meets packaging guidelines
- license (GPLv2) OK
- spec file legible
- source matches upstream
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- package compiles on devel (x86_64)
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime

Additional notes:
- Perhaps "ArcadeGame" to the desktop/menu category?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.