[Bug 454940] Review Request: rcssbase - Base libraries for Robocup Soccer Server (2D)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rcssbase - Base libraries for Robocup Soccer Server (2D)


https://bugzilla.redhat.com/show_bug.cgi?id=454940





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-07-12 12:39 EST -------
For 12.1.0-1:

* License:
------------------------------------------------------------
rcssbase/conf/buildertest.cpp			GPLv2+
rcssbase/lib/factorytest/factorytest.cpp	GPLv2+
rcssbase/lib/loadertest/			GPLv2+
rcssbase/net/addrtest/addrtest.cpp		GPLv2+
rcssbase/net/iosocketstreamtest/iosocketstreamtest.cpp	GPLv2+
rcssbase/net/tcpsockettest/tcpsockettest.cpp	GPLv2+
rcssbase/net/udpsockettest/udpsockettest.cpp	GPLv2+
------------------------------------------------------------
  - %_bindir/rcssmodtest is licensed under GPLv2+.
    So please modify license tag like:
------------------------------------------------------------
Group:          Development/Libraries
# %%{_bindir}/rcssmodtest is licensed under GPLv2+, others
# are under LGPLv2+
License:        LGPLv2+ and GPLv2+
URL:            http://sourceforge.net/projects/sserver/
...
...
%package        devel
Summary:        Header files and libraries for %{name}
Group:          Development/Libraries
License:	LGPLv2+
...
------------------------------------------------------------

* build issue
  - build error:
    Does not build on x86_64:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=709246
    m4/ax_boost_base.m4 cannot deal with /usr/lib64 correctly.
    The following can be a workaround:
------------------------------------------------------------
%prep
%setup -q
%patch0 -p1 -b .gcc43fix
%patch1 -p1 -b .libfix
find -name "*.cpp" -exec chmod a-x {} \;
find -name "*.hpp" -exec chmod a-x {} \;
sed -i.lib \
	-e 's|\$ac_boost_path/lib|\$libdir|' \
	-e 's|$ac_boost_path_tmp/lib|\$libdir|' \
	m4/ax_boost_base.m4
------------------------------------------------------------

   - Undesired autotools call
     build.log shows:
------------------------------------------------------------
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h
config.status: executing depfiles commands
+ sed -i -e 's! -shared ! -Wl,--as-needed\0!g' libtool
+ make -j4
cd . && /bin/sh /builddir/build/BUILD/rcssbase-12.1.0/missing --run autoheader
rm -f stamp-h1
touch config.h.in
cd . && /bin/sh ./config.status config.h
config.status: creating config.h
config.status: config.h is unchanged
make  all-recursive
make[1]: Entering directory `/builddir/build/BUILD/rcssbase-12.1.0'
------------------------------------------------------------
     Here autoheader is called after configure is finished, which is
     not desired. Usually this means timestamps on some autotool related files
     are not right.
     Using "autoreconf -f -i" instead of "autotool -i" fixes this issue

   - And please move autoreconf call from %build to at the last of %prep.

* configure option
  - build.log shows:
------------------------------------------------------------
   289  checking for deflate in -lz... 
   290  no
   449  checking ltdl.h usability... 
   450  no
   451  checking ltdl.h presence... 
   452  no
   453  checking for ltdl.h... no
   454  checking whether to use included libltdl... 
------------------------------------------------------------
    However both zlib-devel and libtool-ltdl-devel are available so
    please add these to BuildRequires.

* Timestamps
  - For this package CPPROG="cp -p" is not needed as this package does not
    use install-sh.

* rpath 
  - rpath check does not pass on 64 bit (currently koji down and I cannot
    post the build result done on koji build
    The following can be a workaround:
------------------------------------------------------------
autoreconf -fi
# Fix rpath
sed -i.rpath -e '/sys_lib_search_path_spec/s| /usr/lib| /lib64 /usr/lib64
/usr/lib|' \
	configure
------------------------------------------------------------
    (again please move autoconf call to %prep)
  

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.