[Bug 450243] Review Request: google-gadgets - Google Gadgets for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: google-gadgets - Google Gadgets for Linux


https://bugzilla.redhat.com/show_bug.cgi?id=450243


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-07-13 10:18 EST -------
For 0.9.3-1:

* Version
  - Well, during the time that this bug was assigned to nobody, the upstream
    version is changed to 0.10.0... Would you upgrade again?

* Timestamps
  - To keep timestamps on installed files, please consider to use:
------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" CPPROG="cp -p"
------------------------------------------------------
    Actually this saves most of the files to be installed

    - 'INSTALL="install -p"' usually works for recent autotools based Makefiles
    - And 'CPPROG="cp -p"' usually works for Makefiles using "install-sh" for
      installation.

* Dependency
  - Please check for -devel subpackage.
    A. For example, libggadget-dbus-1.0.pc contains the line:
------------------------------------------------------
Requires: libggadget-1.0 dbus-1
------------------------------------------------------
       This means -devel subpackage should have "Requires: dbus-devel"

    B. Another example is that %_includedir/google-gadgets/ggadget/gtk/tooltip.h
       contains:
------------------------------------------------------
    19  
    20  #include <gtk/gtk.h>
    21  
------------------------------------------------------
       This means that -devel subpackage should have "Requires: gtk2-devel".

Then:
(In reply to comment #6)
> Disabling -qt for now sounds good to me: maybe you can make it a build option
> for the future?
  I feel that enabling qt side does not seem to be bad, however would you tell us
  your opinion?


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.