[Bug 454960] Review Request: aubio - An audio labelling library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: aubio - An audio labelling library


https://bugzilla.redhat.com/show_bug.cgi?id=454960





------- Additional Comments From j.w.r.degoede at hhs.nl  2008-07-13 15:06 EST -------
I can still not approve this I'm afraid, it now fails to build on my system with:
RPM build errors:
    File not found by glob:
/var/tmp/aubio-0.3.2-2.fc10-root-hans/usr/lib64/python2.5/site-packages/aubio/*.so
    Installed (but unpackaged) file(s) found:
   /usr/lib/python2.5/site-packages/aubio/_aubiowrapper.so

Notice the lib64 in the path it is looking for, which is correct, you use 
%{python_sitearch}/%{name}/*.so

and sitearch is in lib64 on x86_64, and looking for the .so in sitearch is
correct, that is where it should be. So appearantly the aubio makefile gets this
wrong.

Note that it is allowed to put the entire python stuff in sitearch if it depends
upon a .so, so you could see if you can override the makefile install location
for the python stuff and just put it all in sitearch.

Also note that currently in your %files section, the %{python_sitearch}/%{name}
directory will be unowned when different from %{python_sitelib}/%{name}

Hmm, thinking some more about this, it would really be the cleanest to put all
of the python stuff in sitearch as it depends on a .so, if you cannot persuade
the makefile todo this you could use something like this after "make install":
if [ %{python_sitearch} != %{python_sitelib} ]; then
  mkdir -p $RPM_BUILD_ROOT%{python_sitearch}
  mv $RPM_BUILD_ROOT%{python_sitelib}/%{name} $RPM_BUILD_ROOT%{python_sitearch}
fi

This will also greatly simplify the %files for the -python package, that can
then become plain and simple:

%files python
%defattr(-,root,root,-)
%{python_sitearch}/%{name}


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.