[Bug 430429] Review Request: python-storm - An object-relational mapper (ORM) for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-storm - An object-relational mapper (ORM) for Python


https://bugzilla.redhat.com/show_bug.cgi?id=430429





------- Additional Comments From michel.sylvan at gmail.com  2008-07-14 15:25 EST -------
PSF = Python Software Foundation license, the same license as Python itself.
It's GPL-compatible so it's also LGPL-compatible (see
/usr/share/doc/python-2.5.1/LICENSE)

As for the copyright-assignment, that's the same rule used by the Free Software
Foundation; I believe it only applies to contributions that is to be
incorporated into upstream.

I'll ask upstream about the missing copyright; the commit log for that file
shows that Gustavo Niemeyer, who writes the rest of Storm, committed it, so
unless we hear otherwise it should probably be OK.

Unit tests are now run (need to probably ask the maintainer of rpmdevtools to
add it to the skeleton specs)

I've now included only %{python_sitelib}/storm* -- this includes the egginfo
automatically, and lets us avoid having to use an %if test -- the test will get
annoying once RHEL's python supports eggs as well

The last thing is the exclusion of files -- it achieves the same result as using
rm, and is safer as you can't accidentally clobber files outside the buildroot.

http://salimma.fedorapeople.org/for_review/python/python-storm-0.12-2.fc9.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.