[Bug 445027] Review Request: dnrd - A caching, forwarding DNS proxy server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dnrd - A caching, forwarding DNS proxy server


https://bugzilla.redhat.com/show_bug.cgi?id=445027





------- Additional Comments From kevin at tummy.com  2008-07-14 21:53 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
See below - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
41c9b070aae8ed403fc8c2aac7ab157c  dnrd-2.20.3.tar.gz
41c9b070aae8ed403fc8c2aac7ab157c  dnrd-2.20.3.tar.gz.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
See below - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version

Issues:

1. There looks to be a slight license issue.
The qid.h file appears to be under just the GPLv2, while everything else is either
GPLv2+ or "Public domain". So, the entire package looks like it will be under GPLv2.
You might however talk to upstream about this and see thats what the intend.
They might have just missed a file in a relicense.

2. You have a file listed twice in %files:
warning: File listed twice: /etc/dnrd/dnrd.conf
You probibly want to make the %{_sysconfdir}/%{name} just use a %dir to only include
the directory there.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.