[Bug 454895] Review Request: sitecopy - Tool for easily maintaining remote web sites

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sitecopy - Tool for easily maintaining remote web sites


https://bugzilla.redhat.com/show_bug.cgi?id=454895





------- Additional Comments From kevin at tummy.com  2008-07-15 15:16 EST -------
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
See below - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
df48499ad81b333a9d255c1709e09a1a  sitecopy-0.16.3.tar.gz
df48499ad81b333a9d255c1709e09a1a  sitecopy-0.16.3.tar.gz.orig
See below - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.   
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. The License tag here should be:
GPLv2+
as far as I can see. All the source files say "or any later version".

2. From the build output:
checking for neon-config... none
configure: no external neon library found
configure: using bundled neon (0.26.0)
You seem to be missing a 'BuildRequires: neon-devel' ?

Possibly also:
configure: zlib not supported
configure: SSL support is not enabled

zlib-devel and openssl-devel ?

There might also be some gettext or the like BuildRequires missing, as
configure reports:
  Internationalization:  Built using native support



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.