[Bug 448717] Review Request: gnome-rdp - rdesktop front end

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-rdp - rdesktop front end


https://bugzilla.redhat.com/show_bug.cgi?id=448717





------- Additional Comments From fedora at christoph-wickert.de  2008-07-15 18:59 EST -------
(In reply to comment #5)
> Also since the package came with a .desktop file, I'm using
> desktop-file-validate instead of desktop-file-install, which was suggested to me
> in #fedora-devel.

Well, but if you used desktop-file-install you wouldn't need the
gnome-rdp-desktop-validate.patch any more. Simply use

  desktop-file-install --vendor=""                           \
    --remove-category="Internet"                             \
    --delete-original                                        \
    --dir=%{buildroot}%{_datadir}/applications               \
    %{buildroot}/%{_datadir}/applnk/Multimedia/foo.desktop

and drop the patch. _If_ you use desktop-file-install you need to check the file
before it is installed and not afterwards. At the moment you are running
desktop-file-validate after make install.

A few more comments:

- License tag in the spec is wrong. Please take a look at the headers of the
files inside src:
"... either version 2 of the License, or (at your option) any later version."
"or later" means GPLv2+ instead of GPLv2.

- You are using find_lang, but you forgot to build require gettext. You'll also
need perl(XML::Parser).

- %{_libdir}/gnome-rdp/ is unowned and will be left over if you uninstall
gnome-rdp. Change 
  %{_libdir}/gnome-rdp/gnome-rdp.exe to
  %{_libdir}/gnome-rdp/
so the whole directory is included.

%{_datadir}/man/man1/gnome-rdp.1.gz should be
%{_mandir}/man1/gnome-rdp.1.gz (or %{_mandir}/man1/%{name}.1.gz)

- Include AUTHORS, ChangeLog and README in %doc, but not INSTALL (because it's
generic) and NEWS (empty)

- mock builds fail:

Ausführung(%build): /bin/sh -e /var/tmp/rpm-tmp.pA6JFs
+ umask 022
+ cd /builddir/build/BUILD
+ cd gnome-rdp-0.2.2.3
+ LANG=C
+ export LANG
+ unset DISPLAY
+ autoconf
aclocal.m4:14: error: this file was generated for autoconf 2.61.
You have another version of autoconf.  If you want to use that,
you should regenerate the build system entirely.
aclocal.m4:14: the top level
autom4te: /usr/bin/m4 failed with exit status: 63
Fehler beim Bauen des RPMS:
Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.pA6JFs (%build)
    Fehler-Status beim Beenden von /var/tmp/rpm-tmp.pA6JFs (%build)
Child returncode was: 1

Please install mock and try to build the package against rawhide. You'll
possibly need "autoreconf -f" instead of autoconf. 

And this time please increase the release, so the new package would be
0.2.2.3-2. This makes it easier for the reviewers to distinguish between
different packages. We need to be able to track your changes, so please include
proper information in %changelog.

If you have problems please let me know.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.