[Bug 455544] Review Request: cx18-firmware - Firmware for Conexant cx23418-based video capture devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cx18-firmware - Firmware for Conexant cx23418-based video capture devices


https://bugzilla.redhat.com/show_bug.cgi?id=455544


axel.thimm at atrpms.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|axel.thimm at atrpms.net       |
         AssignedTo|nobody at fedoraproject.org    |axel.thimm at atrpms.net
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From axel.thimm at atrpms.net  2008-07-16 01:55 EST -------
Good:

- package meets naming guidelines
- package meets packaging guidelines
- firmware license OK, text in %doc, matches source
- spec file legible/english
- source matches upstream
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- does not need to own all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.