[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs


https://bugzilla.redhat.com/show_bug.cgi?id=448215





------- Additional Comments From vpivaini at cs.helsinki.fi  2008-07-18 16:00 EST -------
Updated spec: http://vpv.fedorapeople.org/packages/mozvoikko/mozvoikko.spec
New SRPM:
http://vpv.fedorapeople.org/packages/mozvoikko/mozvoikko-0.9.5-0.2.fc9.src.rpm

(In reply to comment #9)
> If I understand correctly, using xulrunner-unstable makes this prone to breakage
> on updates - is there some versioned dependency towards some package that could
> be used so that it would be easier to notice such cases?

I've now asked about this on fedora-devel, we'll see if there are any comments.
Voikko upstream developers told me there's quite rarely breakage with the
unstable headers mozvoikko uses. I've added a patch which modifies
Makefile.xulrunner so that xulrunner-devel-unstable is not needed anymore, but I
think that won't actually change the situation, because the same headers are
just included from a different directory now.

(The new testing version which was released today just modified
Makefile.xulrunner in a way which made it simpler for Debian, but it didn't work
on Fedora, so upstream will continue with 0.9.5.)

> The dependency on libvoikko works, but as the sources hardcode libvoikko.so.1
> and libmalaga.so.7, it could be good to have the dependency to those sonames. 
> I've done that in the pcsc-perl package, check it out for an example if you
> agree implementing that would be feasible.

Done, I haven't yet built the package on 64 bit, though, but it should work
there as well.

> Would Applications/Internet be a better Group: value?  Aren't all Mozilla apps
> this package works with Internet related ones?

Changed. To me it doesn't really matter that much, but this is probably better.

> When other Mozilla apps that can use this are shipped in Fedora, the dependency
> on firefox should probably be dropped, right?

Yes. My current plan of doing this is to put the files into
%{_libdir}/mozilla/extensions/%{firefox_app_id}/%{firefox_ext_id} as is done now
and then symlink them to %{_libdir}/mozilla/extensions/<{thunderbird, seamonkey}
app id here>/%{firefox_ext_id}. This would mean that the mozvoikko package would
have to co-own those directories together with the firefox, thunderbird and
seamonkey packages, but then any actual dependencies to the applications (except
xulrunner of course) could be dropped.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.