[Bug 455581] Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pecl-ssh2 - php bindings to the functions of libssh2


https://bugzilla.redhat.com/show_bug.cgi?id=455581


ivaxer at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ivaxer at gmail.com




------- Additional Comments From ivaxer at gmail.com  2008-07-20 07:47 EST -------
I'm not sponsored yet. I can just pre-review it:

This package does not build for me, using rpmbuild:

configure: error: The required libssh2 library was not found.  You can obtain
that package from http://sourceforge.net/projects/libssh2/
ошибка: Неверный код возврата из /var/tmp/rpm-tmp.85133 (%build)

I think, BuildRequires must have libssh2-devel.

Unofficial package pre-review:
=======
$ rpmlint -i <src.rpm>
php-pecl-ssh2.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 18)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

php-pecl-ssh2.src: E: description-line-too-long Provides bindings to the
functions of libssh2 which implements the SSH2 protocol.
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.

$ rpmlint -i <rpm>
php-pecl-ssh2.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

php-pecl-ssh2.i386: E: description-line-too-long Provides bindings to the
functions of libssh2 which implements the SSH2 protocol.
Your description lines must not exceed 79 characters. If a line is exceeding
this number, cut it to fit in two lines.

- You seem to have mixed tabs and spaces.
- Try wraping description.
- Package does't have any docs. May be write README or consult
reviewer.

Required
=======
[x] package is named according to the Package Naming Guidelines.
[x] md5sum matches for source from srpm and project page.
[-] package licensed with PHP license, but in .spec BSD is written. Why?
[x] spec file is legible and written in American English.
[-] all build dependencies listed in BuildRequires.
[-] tabs and spaces mixed.
[x] all filenames in rpm are in UTF-8.
[-] description is okay, but needs to be wrapped.
[x] no static libraries, no libtool, package does not own files or folders used
by other packages, no %doc.
[-] package builds and compiles using koji. Fix in BuildRequires needed.
[x] consistently used macros.
[x] %clean - present.

Optional
=======
[?] Packaged non stable sources.

[-] = Problem or suggestion, [x] = Checked, ? = No idea.

Ok, just needs some quick fixes in my opinion.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.