[Bug 455989] Review Request: xfce-mcs-plugins-extra - Extra plugins for the Xfce mcs manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce-mcs-plugins-extra - Extra plugins for the Xfce mcs manager


https://bugzilla.redhat.com/show_bug.cgi?id=455989





------- Additional Comments From sundaram at redhat.com  2008-07-20 14:45 EST -------
OK  | MUST: rpmlint is clean
OK  | MUST: The package must be named according to the Package…
OK  | MUST: The spec file name must match the base package…
OK  | MUST: The package must meet the Packaging Guidelines…
OK  | MUST: The package must be licensed with a Fedora approved…

NOK  | MUST: The License field in the package spec file must…

License tag is incorrect. It is GPLv2 and not GPLv2+. Check the copyright
headers under src directory. They are explicitly licensed under GPL v2 only. 

-   | MUST: The spec file must be written in American English.
OK  | MUST: The package must successfully compile and build…
OK  | MUST: All build dependencies must be listed…
OK  | MUST: The spec file MUST handle locales properly…
OK  | MUST: Every binary RPM package which stores shared…
OK  | MUST: If the package is designed to be relocatable…
OK  | MUST: A package must own all directories that it creates
OK  | MUST: A package must not contain any duplicate files 
OK  | MUST: Permissions on files must be set properly. 
OK  | MUST: Each package must have a %clean section
OK  | MUST: Each package must consistently use macros
OK  | MUST: The package must contain code, or permissible 
N/A | MUST: Large documentation files should go in a -doc 
OK  | MUST: If a package includes something as %doc…
N/A | MUST: Header files must be in a -devel package.
N/A | MUST: Static libraries must be in a -static package.
Static files are disabled as per guidelines
N/A | MUST: Packages containing pkgconfig(.pc) files must…
N/A | MUST: If a package contains library files with a suffix…
N/A | MUST: In the vast majority of cases, devel packages must…
OK  | MUST: Packages must NOT contain any .la libtool archives, 
la files are removed correctly as per guidelines
N/A | MUST: Packages containing GUI applications must include…
OK  | MUST: Packages must not own files or directories already
OK  | MUST: At the beginning of %install, each package MUST…
OK  | MUST: All filenames in rpm packages must be valid UTF-8.
OK  | SHOULD: If the source package does not include license 
-   | SHOULD: The description and summary section … translations…
OK  | SHOULD: The package builds in mock
-   | SHOULD: The package builds on all supported architectures
OK  | SHOULD: The reviewer should test that the package…
N/A | SHOULD: If scriptlets are used, those scriptlets must be sane…
N/A | SHOULD: Subpackages other than devel should usually require base…
N/A | SHOULD: The placement of pkgconfig(.pc) files depends on…
OK | SHOULD: If the package has file dependencies outside of shortlist…
OK  | MUST: All build dependencies must be listed…

Install instructions mention that FSF is giving permission to copy, modify and
redistribute. This is incorrect. Only the copyright holders are doing so. That
bit needs to be fixed upstream. Please notify them. 

You might want to pass  --with-gnu-ld  in configure to speed up the process

Please send a patch upstream to remove the hardcoded path you are working around
in your spec file. 






-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.