[Bug 452395] Review Request: lxlauncher - Open source replacement for Asus Launcher of the EeePC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lxlauncher - Open source replacement for Asus Launcher of the EeePC


https://bugzilla.redhat.com/show_bug.cgi?id=452395





------- Additional Comments From sundaram at redhat.com  2008-07-20 21:58 EST -------
OK  | MUST: rpmlint is clean
OK  | MUST: The package must be named according to the Package…
OK  | MUST: The spec file name must match the base package…
OK  | MUST: The package must meet the Packaging Guidelines…
OK  | MUST: The package must be licensed with a Fedora approved…
OK  | MUST: The License field in the package spec file must. 
OK  | MUST: The spec file must be written in American English.
OK  | MUST: The package must successfully compile and build…
OK  | MUST: All build dependencies must be listed…
OK  | MUST: The spec file MUST handle locales properly…
OK  | MUST: Every binary RPM package which stores shared…
OK  | MUST: If the package is designed to be relocatable…
OK  | MUST: A package must own all directories that it creates
OK  | MUST: A package must not contain any duplicate files 
OK  | MUST: Permissions on files must be set properly. 
OK  | MUST: Each package must have a %clean section
OK  | MUST: Each package must consistently use macros
OK  | MUST: The package must contain code, or permissible 
N/A | MUST: Large documentation files should go in a -doc 
OK  | MUST: If a package includes something as %doc…
N/A | MUST: Header files must be in a -devel package.
N/A | MUST: Static libraries must be in a -static package.
N/A | MUST: Packages containing pkgconfig(.pc) files must…
N/A | MUST: If a package contains library files with a suffix…
N/A | MUST: In the vast majority of cases, devel packages must…
OK  | MUST: Packages must NOT contain any .la libtool archives, 
NOK | MUST: Packages containing GUI applications must include…

Shouldn't there be a .desktop file? How am I suppose to test the functionality
of this software or launch it?

NOK  | MUST: Packages must not own files or directories already

Why are you claiming ownership of 
%{_datadir}/desktop-directories/*.directory?

These are owned by redhat-menus package already. 


OK  | MUST: At the beginning of %install, each package MUST…
OK  | MUST: All filenames in rpm packages must be valid UTF-8.
OK  | SHOULD: If the source package does not include license 
-   | SHOULD: The description and summary section … translations…
OK  | SHOULD: The package builds in mock
-   | SHOULD: The package builds on all supported architectures
OK  | SHOULD: The reviewer should test that the package…
N/A | SHOULD: If scriptlets are used, those scriptlets must be sane…
N/A | SHOULD: Subpackages other than devel should usually require base…
N/A | SHOULD: The placement of pkgconfig(.pc) files depends on…
OK | SHOULD: If the package has file dependencies outside of shortlist…
OK  | MUST: All build dependencies must be listed…

Robert, do you want to do the official review? 


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.