[Bug 454166] Review Request: griv - a gtk rivchat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: griv - a gtk rivchat


https://bugzilla.redhat.com/show_bug.cgi?id=454166





------- Additional Comments From wolfy at nobugconsulting.ro  2008-07-21 11:13 EST -------
There are a couple of problems. The major one is that , according to the build
log, the RPMOPT flags are not used:
gcc -DHAVE_CONFIG_H -I. -I..     -I/usr/include/gtk-2.0
-I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/
usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include
-I/usr/include/freetype2   -MT conf.o -MD -MP -MF .deps/
conf.Tpo -c -o conf.o conf.c

while, a few lines above (before %configure) we have:
+ CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic'
+ export CFLAGS

I've just come back from vacation and I do not have the time for a deeper check,
but I suspect that the makefile needs a bit of love.

Minor nitpicks
- there is no need to delete the original desktop file from the tree
- please use either RPMBUILDROOT or rpmbuildroot, but not both
- the Icon tag in the desktop file should either use the full path to the icon
or the icon name without extension ( see Packaging/Guidelines#desktop ) 
- Your idea to create a man page is excellent and once you settle on a final
format of the file, I suggest to send it upstream for inclusion in their next
release. However the current wording needs a bit of improvement. I am not a
native English speaker either, so take the next lines with a grain of salt. I
have included below a slightly modified text for the Description paragraph of
the man page. Feel free to use it (or not):

DESCRIPTION
  griv is a serverless lan chat program, with the protocol based on RivChat by
Arkadiusz Kolacz (Wielebny K.)
  The specification is available at .........



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.