[Bug 456033] DeviceKit-disks - Disk Management Service

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 21 15:22:48 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: DeviceKit-disks - Disk Management Service


https://bugzilla.redhat.com/show_bug.cgi?id=456033





------- Additional Comments From mclasen at redhat.com  2008-07-21 11:22 EST -------
package name: ok
spec file name: ok
packaging guidelines:
 - the source tag points to a nonexisting file. Should just make it a filename
   and add a comment explaining that this is a git snapshot (see
   https://fedoraproject.org/wiki/Packaging/SourceURL)
 - the handling of %doc content should be straightened out
license: ok
license field: ok
license file: ok
spec language: ok
spec legibility: ok
upstream sources: ok
buildable: yes
ExcludeArch: n/a
BuildRequires: see above, missing device-mapper-devel and intltool
locale handling: n/a
ldconfig: n/a
relocatable: n/a
directory ownership: 
  - must not own /usr/share/PolicyKit/policy
duplicate files: ok
permissions: ok
%clean: ok
macro use: ok
content: permissible
large docs: n/a
%doc content: ok
header files: n/a
static libraries: n/a
pc files: n/a
shared libraries: n/a
devel deps: ok
libtool archives: ok
gui apps: n/a
directory ownership:
  - see above about /usr/share/PolicyKit/policy
%install: ok
utf8 filenames: ok


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list