[Bug 455788] Review Request: perl-DateTime-Format-DBI - Find a parser class for a database connection

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DateTime-Format-DBI - Find a parser class for a database connection


https://bugzilla.redhat.com/show_bug.cgi?id=455788


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From panemade at gmail.com  2008-07-22 01:12 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build=>http://koji.fedoraproject.org/koji/taskinfo?taskID=722957
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
97efe8dfe3a6e68cfb9489c451cd16dd  DateTime-Format-DBI-0.031.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=1,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.04 cusr  0.00 csys
=  0.05 CPU)
+ Package perl-DateTime-Format-DBI-0.031-1.fc10 =>
  Provides: perl(DateTime::Format::DBI) = 0.0
  Requires: perl(Carp) perl(DBI) >= 1.21 perl(strict) perl(vars)


I am not sure why provides is giving 0.0 whereas I can see code 
$VERSION = '0.031';
$VERSION = $VERSION + 0.0;
shouldn't it be summed to 0.031 ?





-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.