[Bug 453870] Review Request: iw - A nl80211 based wireless configuration tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: iw - A nl80211 based wireless configuration tool


https://bugzilla.redhat.com/show_bug.cgi?id=453870


lkundrak at v3.sk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From lkundrak at v3.sk  2008-07-22 06:14 EST -------
Adel: Thanks for the package.

1.) I suggest you version the dependency on kernel-devel. At least headers from
el5's 2.6.18 are definitely not enough to build this.

2.) The comment that explains how to generate the source tarball should describe
how to reproduce the very same sourece tree, and I guess that I'll get a more
recent version if I did a simple git clone now. You should probably add a SHA
hash of the tree you are packaging, or whatever nonsense does GIT use instead of
revision numbers :)

Not really a blockers though -- there's nothing you can do wrong when doing that
at import time.

In all other respect, the package is perfect. Nice work. RPMlint is happy, SPEC
file is sane and legible, compiler flags are honoured. Therefore the package is

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.