[Bug 456309] Review Request: perl-Apache2-SOAP - A replacement for Apache::SOAP designed to work with mod_perl 2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Apache2-SOAP - A replacement for Apache::SOAP designed to work with mod_perl 2


https://bugzilla.redhat.com/show_bug.cgi?id=456309


xavier at bachelot.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |xavier at bachelot.org
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From xavier at bachelot.org  2008-07-22 20:08 EST -------
+ source files match upstream : e0c376abd24b9b494d0ee60b8eeecefb
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ latest version is being packaged.

- BuildRequires are proper :
BR: mod_perl-devel is not needed, it's already brought in by BR: perl(ModPerl::MM).

+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock.
+ package installs properly
+ rpmlint is silent
+ final provides and requires are sane

? %check is present and all tests pass
I'm not sure make test will succeed inside of koji.

+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

Everything but the superfluous BuildRequires: looks good. Please fix it before
importing. I'm a bit unsure about what to do with the tests, but it can still be
fixed later if koji doesn't like them. Also, I'm not fond of the perlname define
but this is cosmetic.
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.