[Bug 454029] Review Request: perl-Catalyst-Model-DBIC-Schema - DBIx::Class::Schema Model Class

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Catalyst-Model-DBIC-Schema - DBIx::Class::Schema Model Class


https://bugzilla.redhat.com/show_bug.cgi?id=454029


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |456362




------- Additional Comments From cweyl at alumni.drew.edu  2008-07-23 02:03 EST -------
(In reply to comment #2)
> I guess this should be removed: BuildRequires:  /usr/bin/catalyst.pl

Though catalyst.pl has always been in the Catalyst-Runtime dist, until 5.7014-2
of perl-Catalyst-Runtime it actually lived in perl-Catalyst-Devel... At that
point it was pushed into a subpackage of perl-Catalyst-Runtime-scripts.

catalyst.pl is used at build-time in this package to test Catalyst::Model::DBIC
in a little test-app.

I decided on a file build dep rather than a package br, as 1) it hasn't always
been in perl-Catalyst-Runtime, and 2) perl pacakges usually leverage non-package
br/reqs, and 3) it may change again if upstream moves it.

> After build appears this strange message:
> Cannot determine perl version info from lib/Catalyst/Model/DBIC/Schema.pm

This is something Module::Install spits out.  AFAIK it's harmless and can be
ignored.
 
> There are many problem with dependencies:
> Test::Kwalitee is missing

Test::Kwalitee is an author test that does not require running, as it does not
test the package functionality.  It's also not currently packaged in Fedora, or
I'd throw it in there anyways :)

See https://fedoraproject.org/wiki/Packaging/Perl#When_to_.2Anot.2A_test

> DBIx::Class::Schema::Loader ...missing. (would need 0.03012)

This isn't used at runtime (or at build, for that matter), but by the helper
package Catalyst::Helper::Module::DBIC.  Initially I was leaving this out as
it's not required for runtime usage, but then I realized that dynamic schema
definitions would require it as well.  It's up now and set to block this review
as bug 456362.

> Shouldn't be perl-Catalyst-Devel also in requires?

perl-Catalyst-Devel is not required by any part of this package, at runtime.
When installed, this package provides Catalyst::Helper::Model::DBIC, which
catalyst.pl may use -- but in that case, the dependency is from catalyst.pl to
C::H::M::DBIC.

In any case, perl-Catalyst-Devel shouldn't be required as such -- the virtual
perl(FOO) provides are the preferred method.

See https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.