[Bug 456362] Review Request: perl-DBIx-Class-Schema-Loader - Dynamic definition of a DBIx::Class::Schema

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-DBIx-Class-Schema-Loader - Dynamic definition of a DBIx::Class::Schema


https://bugzilla.redhat.com/show_bug.cgi?id=456362


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-07-23 04:08 EST -------
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=733382
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d9e112493df06800862b93bf46760c4f  DBIx-Class-Schema-Loader-0.04005.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=13, Tests=238, 13 wallclock secs ( 0.05 usr  0.02 sys +  1.58 cusr  0.35
csys =  2.00 CPU)

+ Package perl-DBIx-Class-Schema-Loader-0.04005-1.fc10 =>
Provides:
 perl(DBIx::Class::Schema::Loader) = 0.04005
perl(DBIx::Class::Schema::Loader::Base) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI::DB2) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI::Pg) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI::SQLite) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI::Writing) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI::mysql) = 0.04005
perl(DBIx::Class::Schema::Loader::RelBuilder) = 0.04005

Requires: perl(Carp::Clan) perl(Class::C3) perl(Cwd) perl(DBIx::Class)
perl(DBIx::Class::Schema::Loader::RelBuilder) perl(Data::Dump) perl(Digest::MD5)
perl(File::Spec) perl(Lingua::EN::Inflect::Number) perl(POSIX)
perl(Scalar::Util) perl(Text::Balanced) perl(UNIVERSAL::require) perl(base)
perl(strict) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.