[Bug 454207] Review Request: Terminator - Multiple terminals in one window

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Terminator - Multiple terminals in one window


https://bugzilla.redhat.com/show_bug.cgi?id=454207





------- Additional Comments From mathieu.boniface at gmail.com  2008-07-23 14:34 EST -------
Spec URL : http://mat.boniface.googlepages.com/terminator.spec
SRPM URL : http://mat.boniface.googlepages.com/terminator-0.9-4.fc9.src.rpm

(In reply to comment #17)
> well then, fix the %patch line, your package will/should land in rawhide first:)

 - %patch fixed
   I've built it on rawhide and it seems that's ok
 
> and do not forget about the desktop file:
> terminator.noarch: E: invalid-desktopfile
/usr/share/applications/terminator.desktop

- rpmlint is silent for me (on F9) but desktop-file-validate says :

  [builder at localhost data]$ desktop-file-validate terminator.desktop 
  terminator.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated

  Also, terminator.desktop doesn't include special characters, so I think that's
useless to put the encoding key into.
  

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.