[Bug 454125] Review Request: gtest - Google C++ testing framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gtest - Google C++ testing framework


https://bugzilla.redhat.com/show_bug.cgi?id=454125


rakesh.pandit at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From rakesh.pandit at gmail.com  2008-07-24 01:26 EST -------

Package APPROVED
Package build successfully (ppc, ppc64, i386, x86_64)

Required
[x] rpmlint output -- clean
[x] package naming
[x] spec file name
[x] packaging guidlines 
[x] license approved
[x] license field in spec
[x] license file
[x] language used in spec file -- American English
[x] spec file -- legible
[x] Source0 link 
     md5sum
     upstream - 669530b4399d8e02c1c96483bd939f6c 
     package source - 669530b4399d8e02c1c96483bd939f6c 
[x] package build in mock
[x] BuildRequires 
[NA] locales
[NA] relocatable
[x] owns directory it creates in %{doc}
[x] duplicate files not present
[x] %clean & %install section contain rm -rf $RPM_BUILD_ROOT
[x] permissible package content 
[x] file encoding - utf-8
[x] file permissions -- correct
[x] package has no dependency on files in %doc
[NA] GUI
[x] -devel subpackage only has symlinks so ldconfig not required in subpackage
[x] *.la libtool archives removed
[x] base devel package requirement
     fully versioned dependency
     Requires: %{name} = %{version}-%{release} Checked

Optional
[NA] Query upstream regarding license
[NA] Translation for description and summary available
[x] Package build in mock for most of architectures 
[NA] scripts used
[x] No dependencies outside FHS guidelines


Optional suggestions: None

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.