[Bug 447599] Review Request: immix - image mixer

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 24 06:44:06 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: immix - image mixer


https://bugzilla.redhat.com/show_bug.cgi?id=447599


lxtnow at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED
               Flag|fedora-review?,             |fedora-review+
                   |needinfo?(lxtnow at gmail.com) |




------- Additional Comments From lxtnow at gmail.com  2008-07-24 02:44 EST -------

OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
BAD	license field matches the actual license.
OK	license is open source-compatible (LGPLv3+). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
N/A	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in koji (Rawhide/x86_64).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
OK       Binaries are proper
N/A	%check is present and all tests pass.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets present.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no libtool archives droppings.
OK	GUI app == Desktop file is present and correct.


This package is APPROVED



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list