[Bug 448874] Review Request: pyroom - PyRoom is a full screen text editor and a clone of Writeroom

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyroom - PyRoom is a full screen text editor and a clone of Writeroom


https://bugzilla.redhat.com/show_bug.cgi?id=448874


rakesh.pandit at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




------- Additional Comments From rakesh.pandit at gmail.com  2008-07-24 13:49 EST -------

Package is APPROVED

Required:
[x] rpmlint output - clean
[x] package name & spec name -- correct. pyroom is acceptable as upstream "py"
[x] packaging guideline
[x] fedora approved license
[x] license field in spec - correct
[x] LICENSE included in %{doc}
[x] spec file -- AMERICAN english
[x] spec file - legible
[x] md5sum
      Upstream: c8d9ff35153554f5388a4f24a0ed0dad
      Source: c8d9ff35153554f5388a4f24a0ed0dad
[x] package successfully compiles and builds (build on koji)
[x] BuildRequires -- correct
[x] Requires -- correct
[x] locales -- handled
[NA] shared libraries, header files and static libraries
[x] owns all directories it creates
[x] file permissions correct
[x] no duplicates in %files section
[x] %install and %clean section have rm -rf $RPM_BUILD
[x] nothing in %doc effects application
[x] GUI -- %{name}.desktop included
[x] all files have valid encoding -- utf8
[x] py files are byte compiled. Included in %files -- so package removal does 
not left behind files
[NA] unnecessary byte compilation -- no py files in bin instead a script used. 

Optional:
[NA] No need to upstream for LICENSE
[?] you may like to check whether description and summary sections are 
available in other
     languages. -- (very much optional)
[x]  builds on koji
[x] script add is sane
[x] no dependencies paths outside FHS guidelines 

Optional Suggestions(you may not consider using them):
1. Use either $RPM_BUILD_ROOT or %{buildroot} consistently
2. you can use '--vendor fedora'
3. There are some extra lines in spec -- you may consider using
     uniform layout
4. %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) is preferred 
BuildRoot tag

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.