[Bug 456723] Review Request: libatasmart - ATA S.M.A.R.T. Disk Health Monitoring Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libatasmart - ATA S.M.A.R.T. Disk Health Monitoring Library


https://bugzilla.redhat.com/show_bug.cgi?id=456723





------- Additional Comments From lpoetter at redhat.com  2008-07-27 18:06 EST -------
(In reply to comment #1)
> [-]	source files match upstream:
> 		it doesn't fbffdc4551dd63368babf6fdd659a4bef8e0e647 vs
> 23116bb3a88fb9ccfbe229ac5a209beb8c80535f

Fixed. Since I am both upstream and the packager I got a bit confused I guess.

> [-]	license field matches the actual license:
> 		The spec says "License: LGPLv2" while the source files say "or (at your
> option) any later version."
> 		Please change to LGPLv2+

Fixed.

(In reply to comment #2)
> One more thing pass %{?_smp_mflags} to the make command.

Fixed.

I uploaded the spec file and the srpm to the same location. I didn't bump the
rpm revision. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.