[Bug 456684] Review Request: pathfinder - X.509 Path Discovery and Validation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pathfinder - X.509 Path Discovery and Validation


https://bugzilla.redhat.com/show_bug.cgi?id=456684





------- Additional Comments From dan at danny.cz  2008-07-28 03:12 EST -------
first part of review is here, but it must build in Rawhide before continuing :-)

OK	source files match upstream:
	    cdad78a08f7fc614da104459714da2f94093fae9  pathfinder-0.2.6-Source.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (LGPLv2+). License text included in package.
OK	latest version is being packaged.
OK*	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
BAD	package builds in mock (Rawhide/x86_64).
??	debuginfo package looks complete.
??	rpmlint is silent.
??	final provides and requires look sane.
??	%check is present and all tests pass.
OK	shared libraries are added to the regular linker search paths.
BAD	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets present (shared libs, new user, service).
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	headers in -devel.
OK	pkgconfig files in -devel.
OK	no libtool .la droppings.
OK	not a GUI app.

- pkgconfig can be removed from BR: as it is taken in by the *-devels
- doesn't build in Rawhide

/usr/lib64/ccache/c++    -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4
-m6/builddir/build/BUILD/pathfinder-0.2.6/dbus/wvdbuslistener.h: In member
function 'void WvDBusListener<P1, P2, E,
E>::dispatch(DB/builddir/build/BUILD/pathfinder-0.2.6/pathclient.cc:114:  
instantiated from here
/builddir/build/BUILD/pathfinder-0.2.6/dbus/wvdbuslistener.h:115: error: cast
from 'DBusMessageIter*' to 'int' loses precision
make[2]: Leaving directory `/builddir/build/BUILD/pathfinder-0.2.6'
make[2]: *** [CMakeFiles/pathclient.dir/pathclient.o] Error 1


- -devel should own the whole %{_includedir}/pathfinder-1/ dir not only the file
 inside it

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.