[Bug 450816] Review Request: alevt - Teletext decoder/browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alevt - Teletext decoder/browser


https://bugzilla.redhat.com/show_bug.cgi?id=450816





------- Additional Comments From mnowak at redhat.com  2008-07-28 12:21 EST -------
[root at dhcp-lab-192 SPECS]# diff -pruN alevt.spec_bak alevt.spec
--- alevt.spec_bak	2008-07-28 17:43:35.364713214 +0200
+++ alevt.spec	2008-07-28 18:13:27.216716710 +0200
@@ -1,32 +1,36 @@
 Name: alevt
 Version: 1.6.2
 Release: 4%{?dist}
-Summary: Teletext decoder/browser
+Summary: This program decodes and displays Videotext/Teletext from a /dev/vbi
device
 Group:  Applications/Multimedia
 License: GPLv2
 URL: http://goron.de/~froese
 Source: http://goron.de/~froese/%{name}/%{name}-%{version}.tar.gz
 Source1: alevt.desktop
 Patch0: alevt-1.6.2-pixmap.patch
+Patch1: alevt-1.6.2-manpath.patch
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires: libX11-devel
 BuildRequires: libpng-devel
 BuildRequires: desktop-file-utils
 
 %description
-This program decodes and displays Videotext/Teletext from a /dev/vbi device.
+AleVT is a teletext/videotext decoder and browser for the
+bttv driver (/dev/vbi) and X11.  It features multiple windows,
+a page cache, regexp searching, built-in manual, and more.
+There's also a program to get the time from teletext and
+one to capture teletext pages from scripts.
+
 
 %prep
 %setup -q
 %patch0 -p1 -b .pixmap
+%patch1 -p1 -b .manpath
 
 %build
-#overwrite $OPT to produce standard Fedora build with propper FLAGS
-
 # alevt does not have standard build system, so we populate OPT, 
-# which is internal build variable to accomodate Fedora opt flags
-
-# will produce lot of garbage on output
+# which is internal build variable to accommodate Fedora opt flags
+# This will produce lot of garbage on output.
 make %{?_smp_mflags} -e OPT="%{optflags}"
 
 
@@ -35,7 +39,7 @@ rm -rf %{buildroot}
 mkdir -p %{buildroot}%{_bindir}
 mkdir -p %{buildroot}%{_mandir}/man1
 
-make USR_X11R6=%{_prefix} MAN=share/man rpm-install
+make USR_X11R6=%{_prefix} MAN=%{_mandir} rpm-install
 desktop-file-install \
 	--dir=%{buildroot}%{_datadir}/applications %{SOURCE1}
 


* It's mostly description, summary and comments changes. Feel free to tweak them. 

* There's bigger change according to hard-coded man path in MAN variable, now,
with patch, it's in Fedora-macro-way.


[root at dhcp-lab-192 BUILD]# cat ../SOURCES/alevt-1.6.2-manpath.patch 
--- alevt-1.6.2/Makefile	2008-07-28 18:08:04.778713433 +0200
+++ alevt-1.6.2/Makefile_manpath	2008-07-28 18:09:28.572715966 +0200
@@ -66,9 +66,9 @@ rpm-install: all
 	install -m 0755 alevt        ${RPM_BUILD_ROOT}$(USR_X11R6)/bin
 	install -m 0755 alevt-date   ${RPM_BUILD_ROOT}$(USR_X11R6)/bin
 	install -m 0755 alevt-cap    ${RPM_BUILD_ROOT}$(USR_X11R6)/bin
-	install -m 0644 alevt.1x     ${RPM_BUILD_ROOT}$(USR_X11R6)/$(MAN)/man1
-	install -m 0644 alevt-date.1 ${RPM_BUILD_ROOT}$(USR_X11R6)/$(MAN)/man1
-	install -m 0644 alevt-cap.1  ${RPM_BUILD_ROOT}$(USR_X11R6)/$(MAN)/man1
+	install -m 0644 alevt.1x     ${RPM_BUILD_ROOT}$(MAN)/man1
+	install -m 0644 alevt-date.1 ${RPM_BUILD_ROOT}$(MAN)/man1
+	install -m 0644 alevt-cap.1  ${RPM_BUILD_ROOT}$(MAN)/man1
 	install -d 0755 $(RPM_BUILD_ROOT)$(USR_X11R6)/share/pixmaps
 	install -m 0644 contrib/mini-alevt.xpm $(RPM_BUILD_ROOT)$(USR_X11R6)/share/pixmaps


* When is the last point done, I'll finish the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.