[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information

bugzilla at redhat.com bugzilla at redhat.com
Tue Jul 29 06:20:06 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information


https://bugzilla.redhat.com/show_bug.cgi?id=455443


panemade at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade at gmail.com  2008-07-29 02:20 EST -------
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=744642
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
a8b0aa3e5151a8a6c8b3067625980934  Filesys-Df-0.92.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful!
+ Package perl-Filesys-Df-0.92-2.fc10 =>
Provides: Df.so perl(Filesys::Df) = 0.92
Requires: libc.so.6
 libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) perl >= 0:5.006 perl(Carp)
perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) rtld(GNU_HASH)

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the Fedora-package-review mailing list