[Bug 255721] Review Request: ruby-rrdtool - RRDtool module for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-rrdtool - RRDtool module for Ruby


https://bugzilla.redhat.com/show_bug.cgi?id=255721


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-07-29 13:40 EST -------
Some notes:

* On x86_64, %ruby_sitearch is /usr/lib64/ruby/site_ruby/1.8/x86_64-linux so
  This line
--------------------------------------------------------------------
mkdir -p $RPM_BUILD_ROOT/%{_libdir}/ruby/site_ruby/1.8/i386-linux
--------------------------------------------------------------------
  is useless (and actually seems not needed as:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=745638

* I see test/ subdirectory. If some tests are available, please consider to create
  %check section and execute some tests on that section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.