[Bug 454166] Review Request: griv - a gtk rivchat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: griv - a gtk rivchat


https://bugzilla.redhat.com/show_bug.cgi?id=454166





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-07-30 10:08 EST -------
Created an attachment (id=313000)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=313000&action=view)
Patch to suppress implicit function declaration warning

For -3:

* BR: perl-devel
  - Writing "BuildRequires: perl-devel" is not recommended on Fedora:
    https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

    For this package "BuildRequires: perl(XML::Parser)" is sufficient
    (and even this is redundant because perl(XML::Parser) is required by
     intltool)

* sed -i "s|%{name}.png|%{name}|"
  - Fixing Icon entry on the desktop file after executing desktop-file-install
    leaves a warning like:
---------------------------------------------------------------
   524 
/builddir/rpmbuild/BUILDROOT/griv-0.1.9-3.fc10.i386/usr/share/applications/fedora-griv.desktop:
warning: val
ue "griv.png" for key "Icon" in group "Desktop Entry" is an icon name with an
extension, but there should be no exte
nsion as described in the Icon Theme Specification if the value is not an
absolute path
---------------------------------------------------------------
    Fix griv.desktop(.in) before desktop-file-install is called (generally
    modifying griv.desktop.in in %prep is preferred)

! Misc issue
  - Please consider to apply the patch attached to suppress implicit function
    declaration function warning.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.