[Bug 457213] Review Request: html2text - HTML-to-text converter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: html2text - HTML-to-text converter


https://bugzilla.redhat.com/show_bug.cgi?id=457213





------- Additional Comments From jeffperry_fedora at sourcesink.com  2008-07-30 21:04 EST -------
Ok, now for some SHOULDs..

OK - If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
    README contains license text

OK? - description and summary sections in the package spec file should contain
translations for supported Non-English languages, if available.
    Description is present in english and german. 
    The program does not seem to have separate localiztion file (.po)
    Examined ".C" files - no sign of other languages either.
    Given only one supported language maybe should only describe in that
    language in the .spec file?? I have seen other places though (libical)
    describe in multiple langs even though not localized for them.
    Probably not an issue.

OK - The reviewer should test that the package builds in mock
     Tested Fedora 10 target on mock local machine - OK
     Tested Fedora 10 target via koji - OK on all 5 platforms

OK - The package should compile and build into binary rpms on all supported
architectures.
     Tested Fedora 10 target via koji - OK on all 5 platforms

OK - The reviewer should test that the package functions as described. A package
should not segfault instead of running, for example.

   Tested with several internet sites - OK
   Tested with with several html files - initially fetched by wget of a web site
url - OK

OK - If scriptlets are used, those scriptlets must be sane
    Look reasonable to me.

NEEDSWORK
    - No uninstall support? 

OK - Usually, subpackages other than devel should require ...
   No subpackages.

OK - The placement of pkgconfig(.pc) files depends...
   No such files included.

OK - If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin....
   No outside dependencies.

Ok that covers the SHOULDs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.